]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Add folder dialog to overview group
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 4 Jun 2020 04:37:31 +0000 (01:37 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 9 Jun 2020 19:01:08 +0000 (16:01 -0300)
Right now, the app folder dialog isn't really a dialog,
since it is actually added to the AppDisplay. Furthermore,
having it added in AppDisplay may mess up with its sizing
calculations, since AppDisplay has a ClutterBinLayout and
the folder dialog has a fairly large minimum size.

Add the folder dialog to the overview group. Next commits
will adjust various actors to be able to better handle it.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1301

js/ui/appDisplay.js

index 8931ca4a163868c78420fef7a3043097dbfcbf2b..ef36f8b675bf0966371a267cad848d7f855a4798 100644 (file)
@@ -728,7 +728,7 @@ class AppDisplay extends BaseAppView {
     }
 
     addFolderDialog(dialog) {
-        this.add_child(dialog);
+        Main.layoutManager.overviewGroup.add_child(dialog);
         dialog.connect('open-state-changed', (o, isOpen) => {
             this._eventBlocker.visible = isOpen;
 
@@ -1759,6 +1759,8 @@ var AppFolderDialog = GObject.registerClass({
         if (!this._isOpen)
             return;
 
+        this.get_parent().set_child_above_sibling(this, null);
+
         this._needsZoomAndFade = true;
         this.show();